Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support all bottlerocket configuration #2081

Merged
merged 2 commits into from
Jul 13, 2022
Merged

feat: support all bottlerocket configuration #2081

merged 2 commits into from
Jul 13, 2022

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Jul 8, 2022

Fixes #
#2059

Description

  • Accept all bottlerocket config rather than limiting to a subset of config options.

How was this change tested?

  • Unit Tests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Jul 8, 2022 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit f02d47e
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62c8558b152cf3000923a61d

@bwagner5 bwagner5 marked this pull request as ready for review July 8, 2022 16:28
@bwagner5 bwagner5 requested a review from a team as a code owner July 8, 2022 16:28
@bwagner5 bwagner5 requested review from tzneal and suket22 July 8, 2022 16:28
tzneal
tzneal approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/cloudprovider/aws/amifamily/bootstrap/bottlerocketsettings.go
// BottlerocketConfig is the root of the bottlerocket config, see more here https://github.com/bottlerocket-os/bottlerocket#using-user-data
type BottlerocketConfig struct {
SettingsRaw map[string]interface{} `toml:"settings"`
Settings BottlerocketSettings `toml:"-"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was some magic decoding thing at first where it would pick out just the kubernetes settings 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't that be nice!

suket22
suket22 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@suket22 suket22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

pkg/cloudprovider/aws/amifamily/bootstrap/bottlerocketsettings.go Show resolved Hide resolved
@bwagner5 bwagner5 merged commit b1d6dd9 into aws:main Jul 13, 2022
@bwagner5 bwagner5 deleted the br-settings branch July 13, 2022 18:09
This was referenced Jul 13, 2022
Closed
Merged
@suket22 suket22 mentioned this pull request Jul 21, 2022
Merged
3 tasks
@lucass4 lucass4 mentioned this pull request Jan 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suket22 suket22 suket22 approved these changes

@tzneal tzneal tzneal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwagner5 @tzneal @suket22